List of things that have come up during mentoring and reviews, with lessons and teachings in response to them.
Q: Did this pass QA? Review TEST PLAN section was empty. 1
- Lesson: There should be no "open questions". Be explicit. QA should be explicit
- A: QA properly and completely (portlint, poudriere, make universe, et al)
Use these port testing commands until you setup poudriere. 2
Example TEST PLAN section in Phabricator * portlint: OK (looks fine.) * testport: OK (poudriere: <versions>, <archs>, <OPTIONS> tested) * maketest: OK (XXX of YYY tests PASS)
The difference between these commands and poudriere is the isolation of the build environment from the local system which can pickup several additional classes of issues (2)